compilers: Add optimization=plain option#10593
Merged
jpakkane merged 1 commit intomesonbuild:masterfrom Oct 9, 2022
Merged
Conversation
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #10593 +/- ##
===========================================
- Coverage 68.84% 50.36% -18.48%
===========================================
Files 406 203 -203
Lines 88000 44085 -43915
Branches 19546 9777 -9769
===========================================
- Hits 60581 22203 -38378
+ Misses 22850 19877 -2973
+ Partials 4569 2005 -2564
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jtojnar
force-pushed
the
plain-no-optimization
branch
from
21f9d0d to
55b99e1
Compare
Member
|
@dcbaker I did say that PR was going to break things... |
Member
|
I mean, it was already broken with clang, which means it was broken for nix with macos anyway, it just got noticed now that gcc and clang have the same behavior :/ |
Member
|
The change makes sense to me anyway. Should we ensure that |
jtojnar
force-pushed
the
plain-no-optimization
branch
from
55b99e1 to
a725d49
Compare
jtojnar
commented
Jul 12, 2022
jtojnar
force-pushed
the
plain-no-optimization
branch
from
a725d49 to
e8405bb
Compare
dcbaker
approved these changes
Jul 13, 2022
jtojnar
force-pushed
the
plain-no-optimization
branch
from
e8405bb to
7506511
Compare
jtojnar
commented
Jul 18, 2022
mesonbuild#9287 changed the `optimization=0` to pass `-O0` to the compiler. This change is reasonable by itself but unfortunately, it breaks `buildtype=plain`, which promises that “no extra build flags are used”. `buildtype=plain` is important for distros like NixOS, which manage compiler flags for optimization and hardening themselves. Let’s introduce a new optimization level that does nothing and set it as the default for `buildtype=plain`.
jtojnar
force-pushed
the
plain-no-optimization
branch
from
7506511 to
70663f6
Compare
Contributor
Author
|
Made the changelog more explicit about the breakage. |
Member
|
Cool. systemd has acknowledged the issue, and is only waiting on this PR to merge before proposing a fix. |
Contributor
Is this not going to be merged? |
Member
|
Test failure is unrelated. |
UTsweetyfish
pushed a commit
to UTsweetyfish/systemd
that referenced
this pull request
Jul 14, 2023
meson 0.64 introduced optimization plain option. Ref: systemd/systemd#25677 Ref: mesonbuild/meson#10593
UTsweetyfish
added a commit
to UTsweetyfish/systemd
that referenced
this pull request
Jul 14, 2023
meson 0.64 introduced optimization plain option. Ref: systemd/systemd#25677 Ref: mesonbuild/meson#10593
UTsweetyfish
added a commit
to deepin-community/systemd
that referenced
this pull request
Jul 14, 2023
meson 0.64 introduced optimization plain option. Ref: systemd/systemd#25677 Ref: mesonbuild/meson#10593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9287 changed the
optimization=0to pass-O0to the compiler. This change is reasonable by itself but unfortunately, it breaksbuildtype=plain, which promises that “no extra build flags are used”.buildtype=plainis important for distros like NixOS, which manage compiler flags for optimization and hardening themselves.Let’s introduce a new optimization level that does nothing and set it as the default for
buildtype=plain.