Proper multimonitor support (2nd try)

[patrick96]

Does brightness detection on a per monitor basis
Averages the brightness of the centers of all monitors to determine the colors
to pass to i3lock (color version)

Calculates the text width to determine the exact position so this should work
with any text

Speed wise, I was quite surprised:
On my desktop (dualmonitor) the old dualmonitor branch takes 4.48 seconds, the
master branch takes 2.5s and the code in this pull-request takes takes 2.9s to
lock

On my laptop (single screen) both this pull-request and the master branch take
1.8s

So the multimonitor functionality does not seem to add that much overhead for
single monitor systems

If this is satisfactory, I think it would solve the problems described in #10 and #70

[AladW]

Hmm, I'm still not fond of the "<<<xrandr" construction, as with #68. More generally, I think the added complexity and specific use case warrants splitting this up to several smaller scripts. (not necessarily just a bunch of files that are sourced, but independent modules)

[patrick96]

By different modules do you mean something like this?
Where the multimonitor variable comes from a command line argument:

if(multimonitor) {
    multi()
} else {
    single()
}

single() {
   // As before
}

multi() {
    while read -r m; do
        ...
    done <<< "$(xrandr)"
}

This way xrandr is only used, if the user explicitly requests multimonitor support.

[patrick96]

Any update on this?

[AladW]

Sorry, this is a rather large pull request and I'm in the middle of the exam period. Regarding your question on modules, it's a start but also more a superficial change. Ideally the functionality could be split in small blocks that would be interconnected (e.g. via pipes).

[patrick96]

Thanks for the quick response. I don't really understand how you want me to split up the functionality, could you give me some example?

Also we don't have to discuss that now, if you don't have time. We can talk about this once exams are over. Good luck on those btw.

[velrest]

is this pr ready for use? i will build my package based on this pr if this is working. Looks like this is not getting merged for a long time.

[patrick96]

Ready for use? Yes, I use it on a daily basis. That being said, I cannot guarantee it will work for everyone else and I will also not provide support for the code.

I will close this PR as I don't have the time to do any more work on this right now or in the near future.

[AladW]

I still plan to look at this at some point, so I'll reopen this PR if you don't mind.

[AladW]

Please test #155. Latter seems to have most of the functionality while being relatively easy to review.