Skip to content

Conversation

danditomaso
Copy link
Collaborator

Description

This PR restore the users own node to both the messages screen and the node list. There has been debate if it should be listed and this PR has determined going forwards all nodes including the node you are connected to will be visible in the UI.

Related Issues

Fixes #870

Changes Made

  • Flipped boolean in Node store to include "self" which is the node you are currently connected to.
  • Added undefined check in Messages to resolve some TypeScript errors.

Testing Done

Opened the webUI and determined the node you are connected to is favouriated and and at the top of the list.

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 19:35
Copy link

vercel bot commented Oct 9, 2025

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the user's own node to the UI by making it visible in both the messages screen and node list. Previously, the user's connected node was hidden from these views.

  • Changed node filtering to include the user's own node in both messages and nodes pages
  • Added undefined check for improved TypeScript safety when accessing the current node
  • Updated type signature to reflect that getMyNode may still return undefined in some cases

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/web/src/pages/Nodes/index.tsx Enable inclusion of user's own node in the nodes list
packages/web/src/pages/Messages.tsx Include user's own node in messages view and add safety check
packages/web/src/core/stores/nodeDBStore/index.ts Update getMyNode return type signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@danditomaso danditomaso merged commit c66b315 into meshtastic:main Oct 11, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Node missing from node list in WebUI only

1 participant