Add protobufs for a in-development traffic management module. - #849
Merged
Conversation
h3lix1
commented
Jan 25, 2026
h3lix1
left a comment
h3lix1
left a comment
Contributor
Author
There was a problem hiding this comment.
I think this should be ready to go..
…s to traffic_management.nodeinfo_direct_response_max_hops
h3lix1
force-pushed
the
traffic_management
branch
from
January 31, 2026 17:19
91016c0 to
55a3604
Compare
Contributor
Author
|
@GUVWAF if you have a minute, can you review? Thank you. |
GUVWAF
approved these changes
Feb 5, 2026
GUVWAF
left a comment
GUVWAF
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Sounds very useful at least for development purposes, don't have any specific comments.
thebentern
approved these changes
Feb 10, 2026
Contributor
|
@h3lix1 can you take a look at the formatting issues. I think the indention on some of the comments is off |
Contributor
Author
|
@thebentern I can't take credit for the fomat issue in telemetry.proto but I'll take the one in module_config.proto. Both are fixed. Or, at least it passes buf format --diff on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds protobufs for changes required to support a traffic management module.
Checklist before merging