Skip to content

fix: avoid memory leak when possibly malformed packet is received #9781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 3 commits into from
Mar 1, 2026
Merged

fix: avoid memory leak when possibly malformed packet is received #9781

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ed3825
avoid memory leak when possibly malformed packet received
m1nl Feb 28, 2026
8840de9
Merge branch 'develop' into fix_channels_memory_leak
m1nl Feb 28, 2026
1f2474a
Merge branch 'develop' into fix_channels_memory_leak
thebentern Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/mesh/Channels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ const char *Channels::serialChannel = "serial";
const char *Channels::mqttChannel = "mqtt";
#endif

meshtastic_Channel dummyChannel = {.index = -1};

uint8_t xorHash(const uint8_t *p, size_t len)
{
uint8_t code = 0;
Expand Down Expand Up @@ -309,13 +311,7 @@ meshtastic_Channel &Channels::getByIndex(ChannelIndex chIndex)
return *ch;
} else {
LOG_ERROR("Invalid channel index %d > %d, malformed packet received?", chIndex, channelFile.channels_count);

static meshtastic_Channel *ch = (meshtastic_Channel *)malloc(sizeof(meshtastic_Channel));
memset(ch, 0, sizeof(meshtastic_Channel));
// ch.index -1 means we don't know the channel locally and need to look it up by settings.name
// not sure this is handled right everywhere
ch->index = -1;
return *ch;
return dummyChannel;
}
}

Expand Down
Loading