Skip to content

skip header items when enabling the InkHUD menu cursor #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 6 commits into from
Feb 20, 2026
Merged

skip header items when enabling the InkHUD menu cursor #9552

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd48ebc
onNavUp() sets the menu cursor to the last item if not shown
zeropt Feb 5, 2026
5b42c11
skip headers when showing the menu cursor in onNavUp() and onNavDown()
zeropt Feb 6, 2026
101a402
skip headers when showing the menu cursor in onButtonShortPress()
zeropt Feb 6, 2026
8b241fd
Merge branch 'develop' into inkhud-menu-cursor-behavior
thebentern Feb 7, 2026
963ee02
brace cursor incrementing
zeropt Feb 7, 2026
d1c806b
Merge branch 'develop' into inkhud-menu-cursor-behavior
HarukiToreda Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,14 @@ void InkHUD::MenuApplet::onButtonShortPress()
if (!settings->joystick.enabled) {
if (!cursorShown) {
cursorShown = true;
// Select the first item that isn't a header
cursor = 0;
while (cursor < items.size() && items.at(cursor).isHeader)
Comment thread
zeropt marked this conversation as resolved.
Outdated
cursor++;
if (cursor >= items.size()) {
cursorShown = false;
cursor = 0;
}
Comment thread
HarukiToreda marked this conversation as resolved.
} else {
do {
cursor = (cursor + 1) % items.size();
Expand Down Expand Up @@ -1576,7 +1583,15 @@ void InkHUD::MenuApplet::onNavUp()

if (!cursorShown) {
cursorShown = true;
cursor = 0;
// Select the last item that isn't a header
cursor = items.size() - 1;
while (items.at(cursor).isHeader) {
if (cursor == 0) {
cursorShown = false;
break;
Comment thread
HarukiToreda marked this conversation as resolved.
}
cursor--;
}
} else {
do {
if (cursor == 0)
Expand All @@ -1597,7 +1612,14 @@ void InkHUD::MenuApplet::onNavDown()

if (!cursorShown) {
cursorShown = true;
// Select the first item that isn't a header
cursor = 0;
while (cursor < items.size() && items.at(cursor).isHeader)
Comment thread
zeropt marked this conversation as resolved.
Outdated
cursor++;
if (cursor >= items.size()) {
cursorShown = false;
cursor = 0;
}
} else {
do {
cursor = (cursor + 1) % items.size();
Expand Down
Loading