Skip to content

action: skip trying to comment binary size change results if it is not a PR #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vidplace7 merged 5 commits into from
Dec 26, 2025
Merged

action: skip trying to comment binary size change results if it is not a PR #9033

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee321e5
action: skip trying to comment binary size change results if it is no…
Jorropo Dec 21, 2025
71a831d
action: fix halucinations in the clanker's code
Jorropo Dec 21, 2025
133e51b
action: cleanup one line
Jorropo Dec 21, 2025
9d6106b
Merge branch 'develop' into shame-master
thebentern Dec 22, 2025
aae630e
Merge branch 'develop' into shame-master
vidplace7 Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/main_matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ jobs:
needs: [build]
steps:
- uses: actions/checkout@v6
if: github.event_name == 'pull_request_target'
with:
filter: blob:none # means we download all the git history but none of the commit (except ones with checkout like the head)
fetch-depth: 0
Expand All @@ -253,18 +254,20 @@ jobs:
uses: actions/upload-artifact@v6
id: upload-manifest
with:
name: manifests-all
name: manifests-${{ github.sha }}
overwrite: true
path: |
manifests-new/*.mt.json
path: manifests-new/*.mt.json
- name: Find the merge base
if: github.event_name == 'pull_request_target'
run: echo "MERGE_BASE=$(git merge-base "origin/$base" "$head")" >> $GITHUB_ENV
env:
base: ${{ github.base_ref }}
head: ${{ github.head_ref }}
head: ${{ github.sha }}
- name: Download the old manifests
run: gh run download -R ${{ github.repository }} --commit ${{ env.MERGE_BASE }} --name manifests-all --dir manifest-old/
if: github.event_name == 'pull_request_target'
run: gh run download -R ${{ github.repository }} --name manifests-${{ env.MERGE_BASE }} --dir manifest-old/
- name: Do scan and post comment
if: github.event_name == 'pull_request_target'
run: python3 bin/shame.py ${{ github.event.pull_request.number }} manifests-old/ manifests-new/

release-artifacts:
Expand Down
Loading