action: skip trying to comment binary size change results if it is not a PR - #9031
Closed
Jorropo wants to merge 0 commit into
Closed
action: skip trying to comment binary size change results if it is not a PR#9031Jorropo wants to merge 0 commit into
Jorropo wants to merge 0 commit into
Conversation
vidplace7
requested changes
Dec 21, 2025
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| shame: | ||
| if: github.repository == 'meshtastic/firmware' |
Member
There was a problem hiding this comment.
Suggested change
| if: github.repository == 'meshtastic/firmware' && github.event_name == 'pull_request_target' |
Member
There was a problem hiding this comment.
You should just be able to add this here
Member
There was a problem hiding this comment.
Also we use pull_request_target not pull_request 👍
Member
Author
There was a problem hiding this comment.
We need Upload combined manifests for later commit and global stats crunching. to run on master & develop.
I am thinking maybe there should be two steps.
But given both needs to download all the manifests to merge them I thought it made sense to have it together as one.
Member
Author
There was a problem hiding this comment.
I changed pull_request_target, opened #9033 since I forgot to make a branch sorry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.