Skip to content

Revert cross-preset default-key bridging with UDP and disable UDP by default - #8130

Merged
thebentern merged 2 commits into
masterfrom
revert-cross-preset
Sep 27, 2025
Merged

Revert cross-preset default-key bridging with UDP and disable UDP by default#8130
thebentern merged 2 commits into
masterfrom
revert-cross-preset

Conversation

@thebentern

@thebentern thebentern commented Sep 27, 2025

Copy link
Copy Markdown
Contributor

It quickly became apparent based on conversations with users on the discord that this feature is extremely controversial and needs to be removed.
Reverts #7753

@thebentern
thebentern changed the base branch from develop to master September 27, 2025 00:17
@thebentern thebentern added the bugfix Pull request that fixes bugs label Sep 27, 2025

@fifieldt fifieldt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas, I've also seen these conversations. We need to talk more before we can have nice things :)

@GUVWAF

GUVWAF commented Sep 27, 2025

Copy link
Copy Markdown
Member

That PR was merely such that if you have nodes on two different presets with the default key, you will be able to decrypt those packets. Bridging happens automatically as UDP is a common medium (except when you set the rebroadcast mode to LOCAL_ONLY). So this doesn't actually decrease channel utilization, it merely makes the packets visible.

IMO we should reconsider whether UDP should be enabled by default.

@thebentern thebentern changed the title Revert cross-preset bridging with UDP Revert cross-preset default-key bridging with UDP Sep 27, 2025
@thebentern

Copy link
Copy Markdown
Contributor Author

That PR was merely such that if you have nodes on two different presets with the default key, you will be able to decrypt those packets. Bridging happens automatically as UDP is a common medium (except when you set the rebroadcast mode to LOCAL_ONLY). So this doesn't actually decrease channel utilization, it merely makes the packets visible.

IMO we should reconsider whether UDP should be enabled by default.

Indeed. I added "default-key" to the title and removed the enabled by default.
We should also consider controls at individual channel levels perhaps re-using uplink / downlink when UDP is enabled.

@thebentern thebentern changed the title Revert cross-preset default-key bridging with UDP Revert cross-preset default-key bridging with UDP and disable UDP by default Sep 27, 2025
@thebentern
thebentern merged commit ab00e99 into master Sep 27, 2025
83 checks passed
@thebentern
thebentern deleted the revert-cross-preset branch September 27, 2025 12:09
@GUVWAF

GUVWAF commented Sep 27, 2025

Copy link
Copy Markdown
Member

Hmm, but why do we need to revert the decryption logic if it still creates the same traffic, just not visible?

Maybe it makes sense to put it back after #8134?

@thebentern

Copy link
Copy Markdown
Contributor Author

Hmm, but why do we need to revert the decryption logic if it still creates the same traffic, just not visible?

Maybe it makes sense to put it back after #8134?

Yeah I think so. I'll cherry pick that change over.

@garthvh

garthvh commented Sep 27, 2025

Copy link
Copy Markdown
Member

Sending faster preset data to slower ones is bad.

@GUVWAF

GUVWAF commented Sep 28, 2025

Copy link
Copy Markdown
Member

Yes, it's definitely not a long-term solution, but mostly for meshes where the majority already moved to a faster preset and are trying to get the remaining nodes over. My point is, however, that currently people may already bridge it, but it happens to be invisible because of non-matching channel hashes.

@VideoFX

VideoFX commented Sep 30, 2025

Copy link
Copy Markdown

I would like to be able to bridge LF and MF for the purpose of migration.

jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
…default (meshtastic#8130)

* Revert cross-preset UDP bridging

* Don't enable UDP by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants