Add `CLIENT_BASE` role: `ROUTER` for favorites, `CLIENT` otherwise (for attic/roof nodes!) - #7873

Merged

thebentern merged 16 commits into

meshtastic:developfrom

compumike:compumike/client-base-role

Sep 12, 2025

Commits on Sep 12, 2025

Rename startTransmitTimerSNR to startTransmitTimerRebroadcast
compumike
committed
7e00054
Pass meshtastic_MeshPacket down into startTransmitTimerRebroadcast and getTxDelayMsecWeighted
compumike
committed
3cc2b70
Add NodeDB::isFavorite, NodeDB::isFromOrToFavoritedNode
compumike
committed
484b4cd
Add RadioInterface::shouldRebroadcastEarlyLikeRouter and add CLIENT_BASE condition
compumike
committed
ab53329
Add FloodingRouter::roleAllowsCancelingDupe and condition for CLIENT_BASE
compumike
committed
b305acf
Fix linter
compumike
committed
b1f55ef
Swap expression order to allow short-circuit evaluation
compumike
committed
c63102a
NodeDB::isFromOrToFavoritedNode: skip search for NODENUM_BROADCAST; one-pass search and early exit
compumike
committed
b768860
Remove changes to src/mesh/generated/meshtastic/config.pb.h from this PR
compumike
committed
5a46337
getTxDelayMsecWeighted and startTransmitTimerRebroadcast: extract p->rxSnr
compumike
committed
27cdd46
Bring src/mesh/generated/meshtastic/config.pb.h from develop after rebase
compumike
committed
4140ecf
Add CLIENT_BASE to DisplayFormatters::getDeviceRole
compumike
committed
527e88c
Fix logic in Screen::shouldWakeOnReceivedMessage and add CLIENT_HIDDEN and CLIENT_BASE to be treated the same as CLIENT and CLIENT_MUTE
compumike
committed
87eff2c
src/graphics/Screen.cpp: move #include "meshUtils.h" outside of "#ifdef HAS_SCREEN" so IS_ONE_OF works on all devices
compumike
committed
4ab125b
NextHopRouter::roleAllowsCancelingFromTxQueue (same logic as FloodingRouter::roleAllowsCancelingDupe)
compumike
committed
35340fc
Fix memory leak in NextHopRouter: always free packet copy when removing from pending
compumike
committed
0fc33c3

Navigation Menu

Uh oh!

Uh oh!

Add `CLIENT_BASE` role: `ROUTER` for favorites, `CLIENT` otherwise (for attic/roof nodes!) - #7873

Add `CLIENT_BASE` role: `ROUTER` for favorites, `CLIENT` otherwise (for attic/roof nodes!)#7873
thebentern merged 16 commits into
meshtastic:developfrom
compumike:compumike/client-base-role

Commits on Sep 12, 2025

Rename startTransmitTimerSNR to startTransmitTimerRebroadcast

Pass meshtastic_MeshPacket down into startTransmitTimerRebroadcast and getTxDelayMsecWeighted

Add NodeDB::isFavorite, NodeDB::isFromOrToFavoritedNode

Add RadioInterface::shouldRebroadcastEarlyLikeRouter and add CLIENT_BASE condition

Add FloodingRouter::roleAllowsCancelingDupe and condition for CLIENT_BASE

Fix linter

Swap expression order to allow short-circuit evaluation

NodeDB::isFromOrToFavoritedNode: skip search for NODENUM_BROADCAST; one-pass search and early exit

Remove changes to src/mesh/generated/meshtastic/config.pb.h from this PR

getTxDelayMsecWeighted and startTransmitTimerRebroadcast: extract p->rxSnr

Bring src/mesh/generated/meshtastic/config.pb.h from develop after rebase

Add CLIENT_BASE to DisplayFormatters::getDeviceRole

Fix logic in Screen::shouldWakeOnReceivedMessage and add CLIENT_HIDDEN and CLIENT_BASE to be treated the same as CLIENT and CLIENT_MUTE

src/graphics/Screen.cpp: move #include "meshUtils.h" outside of "#ifdef HAS_SCREEN" so IS_ONE_OF works on all devices

NextHopRouter::roleAllowsCancelingFromTxQueue (same logic as FloodingRouter::roleAllowsCancelingDupe)

Fix memory leak in NextHopRouter: always free packet copy when removing from pending