Fix: Revert changes on wakeup - #2412
Merged
Merged
Conversation
caveman99
approved these changes
Apr 4, 2023
Contributor
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 4, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to revert a change done in #2403.
The current effect is that during light sleep in mode ROUTER every packet that arrives triggers the screen on (handled as button press).
The previous code was correctly handling this situation, so need to revert to that code.
This issue happens now (after all my previous tests were ok) because now the device correctly wakes up on LORA_DIO1 IRQ, which it didn't do before and the screen on didn't happen. I missed that one.