Revert "feat: Skip Bluetooth wait when Bluetooth is disabled"

[thebentern]

Reverts #10571

This is breaking audio and other things on MUI. We need to figure out a better long term solution but for now, the FSM change causes regressions

Summary by CodeRabbit

• Bug Fixes
  • Corrected the DARK-to-low-power transition timeout to consistently use the configured Bluetooth wait duration.
  • Improved low-power transition behavior when Bluetooth is disabled.

[github-actions]

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 53c0b07d-63e8-4d87-8785-7a0824e7d380

📥 Commits

Reviewing files that changed from the base of the PR and between 98c88d7 and a959aed.

📒 Files selected for processing (1)

• src/PowerFSM.cpp

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The ESP32 DARK-to-LS transition now uses the configured Bluetooth wait duration directly. The removed helpers previously allowed a zero delay when Bluetooth was disabled.

Changes

Bluetooth power wait handling

Layer / File(s)	Summary
DARK-to-LS wait duration src/PowerFSM.cpp	The transition uses the configured or default Bluetooth wait duration directly. The removed helper functions are no longer used.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a959a

This PR restores the prior Bluetooth wait behavior to address regressions affecting audio and other MUI functionality; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jp-bennett, mverch67, h3lix1

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the reverted pull request and the regressions affecting audio and MUI functionality. It does not provide the testing attestations or device testing details requested by the re…	Add the required testing information. State whether the change was tested, identify tested devices, and explain any unavailable hardware or remaining regression risks. Include an issue reference if this change fixes a tracked bug, and remov…
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: reverting the Bluetooth wait behavior. It matches the file changes and pull request objective.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the reverted pull request and the regressions affecting audio and MUI functionality. It does not provide the testing attestations or device testing details requested by the repository template.

Resolution

Add the required testing information. State whether the change was tested, identify tested devices, and explain any unavailable hardware or remaining regression risks. Include an issue reference if this change fixes a tracked bug, and remove the template guidance text if it is present in the final description.

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-10571-power-fsm-disabled-bluetooth-wait

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}