Skip to content

fix static IP on wired ETH #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caveman99 merged 2 commits into from
Aug 10, 2026
Merged

fix static IP on wired ETH #11385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa63cd
fix https://github.com/meshtastic/firmware/issues/11370
caveman99 Aug 10, 2026
61a636b
address coderabbit review
caveman99 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/mesh/wifi/WiFiAPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,25 @@ static int32_t ethNetworkConnectedPoll()
}
#endif

#if defined(USE_WS5500) || defined(USE_CH390D)
// Needs the netif, so only valid after ETH.begin()
static void applyEthStaticIp()
{
if (config.network.address_mode == meshtastic_Config_NetworkConfig_AddressMode_STATIC && config.network.ipv4_config.ip != 0) {
if (!ETH.config(config.network.ipv4_config.ip, config.network.ipv4_config.gateway, config.network.ipv4_config.subnet,
config.network.ipv4_config.dns))
LOG_ERROR("Failed to apply static IP to Ethernet");
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
}
#endif

#ifdef USE_WS5500
// Startup Ethernet
bool initEthernet()
{
if ((config.network.eth_enabled) && (ETH.begin(ETH_PHY_W5500, 1, ETH_CS_PIN, ETH_INT_PIN, ETH_RST_PIN, SPI3_HOST,
ETH_SCLK_PIN, ETH_MISO_PIN, ETH_MOSI_PIN))) {
applyEthStaticIp();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
WiFi.onEvent(WiFiEvent);
#if !MESHTASTIC_EXCLUDE_WEBSERVER
createSSLCert(); // For WebServer
Expand Down Expand Up @@ -135,6 +148,7 @@ bool initEthernet()
#endif
ch390_conf.spi_clock_mhz = 20;
if ((config.network.eth_enabled) && (ETH.begin(ch390_conf))) {
applyEthStaticIp();
WiFi.onEvent(WiFiEvent);
#if !MESHTASTIC_EXCLUDE_WEBSERVER
createSSLCert(); // For WebServer
Expand Down
Loading