Reduce T-Echo firmware footprint to preserve future flash headroom - #11346
Reduce T-Echo firmware footprint to preserve future flash headroom#11346mviotti wants to merge 1 commit into
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PlatformIO configuration adds inherited NRF52840 library exclusions and excludes ChangesT-Echo library configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@mviotti, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
|
I don't think we are actually struggling for flash on this target - NRF pro-micro is at 98% and works. Even if we were, this is not the way to recover flash - we would make a wider change than cherry picking specific devices. |
NomDeTom
left a comment
There was a problem hiding this comment.
This isn't the way to recover flash, and it's not causing a specific problem.
|
Hi @NomDeTom, thanks for the fedback. I will keep it in mind for further contributions. |
Remove the unused BME68x Sensor library from the T-Echo build. The T-Echo only supports the BME280 sensor, so including the BME68x library provides no functional benefit while consuming a significant amount of flash.
Results
Flash usage:
Before: 93.8% (764440 / 815104 bytes)
After: 88.6% (721792 / 815104 bytes)
This reclaims approximately 43 KB of flash (~5% of the available program memory), providing additional headroom for future features and reducing the risk of the T-Echo exceeding its flash limit as the firmware continues to evolve.
Build output before this change:
Build output after this change:
for the
t-echo-inkhudversion, there is also an improvement (this version was also tested):Before the changes:
After the changes:
🤝 Attestations
Summary by CodeRabbit