Skip to content

Add libcurl as a build dependency for meshtasticd packages - #11303

Merged
thebentern merged 1 commit into
developfrom
meshtasticd-libcurl
Jul 31, 2026
Merged

Add libcurl as a build dependency for meshtasticd packages#11303
thebentern merged 1 commit into
developfrom
meshtasticd-libcurl

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Followup to #11214
Adds libcurl as a dependency in Debian and Fedora packages.

Summary by CodeRabbit

  • Chores
    • Updated build dependencies for Debian and RPM packages to support improved package compilation and distribution compatibility.

Followup to #11214
Adds libcurl as a dependency in Debian and Fedora packages.
@vidplace7
vidplace7 requested a review from mverch67 July 31, 2026 13:10
@vidplace7 vidplace7 added the dependencies Pull requests that update a dependency file label Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 121b7060-c9b0-45e3-b064-655e24f2531e

📥 Commits

Reviewing files that changed from the base of the PR and between e2460b5 and d2a9548.

📒 Files selected for processing (2)
  • debian/control
  • meshtasticd.spec.rpkg

📝 Walkthrough

Walkthrough

The Debian and RPM package definitions now declare libcurl build requirements.

Changes

Packaging build requirements

Layer / File(s) Summary
Declare libcurl build requirements
debian/control, meshtasticd.spec.rpkg
The Debian package adds libcurl4-gnutls-dev. The RPM package adds pkgconfig(libcurl).

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mverch67

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change and its context but omits the required testing attestations and testing details. Add testing results, regression checks, affected-device information, and the required attestation section from the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the addition of libcurl as a build dependency for Debian and Fedora meshtasticd packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch meshtasticd-libcurl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thebentern
thebentern enabled auto-merge July 31, 2026 13:32
@thebentern
thebentern added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit 33a0f8f Jul 31, 2026
60 checks passed
@caveman99
caveman99 deleted the meshtasticd-libcurl branch August 26, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants