lint: ignore userPrefs.jsonc - #11174
Conversation
📝 WalkthroughWalkthroughThe lint configuration now ignores ChangesLint configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⚡ Try this PR in the Web FlasherWarning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (30)
Build artifacts expire on 2026-08-23. Updated for |
7edf40d to
dc8818f
Compare
vidplace7
left a comment
There was a problem hiding this comment.
I'd rather not pollute this file with trunk comments.
Let's have trunk ignore userPrefs.jsonc entirely instead.
checkov/CKV_SECRET_6 flags the commented-out "large4cats" example, which is the public default credential for the meshtastic.org MQTT broker rather than a real secret. Ignore the file in .trunk/trunk.yaml so the example config stays free of lint-suppression comments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dc8818f to
c1c1e57
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.trunk/trunk.yaml:
- Around line 105-111: Change the linter scope for the userPrefs.jsonc ignore
entry from ALL to Checkov only, preserving the existing path and exception for
CKV_SECRET_6 while keeping other linters enabled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 66a35abd-6215-4bef-bef1-5dd874a92b60
📒 Files selected for processing (1)
.trunk/trunk.yaml
checkov/CKV_SECRET_6 flags the commented-out "large4cats" example, which is the public default credential for the meshtastic.org MQTT broker rather than a real secret. Ignore the file in .trunk/trunk.yaml so the example config stays free of lint-suppression comments. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
checkov/CKV_SECRET_6 flags the commented-out "large4cats" example, which is the public default credential for the meshtastic.org MQTT broker rather than a real secret. Ignore the file in .trunk/trunk.yaml so the example config stays free of lint-suppression comments. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
checkov/CKV_SECRET_6 flags the commented-out "large4cats" example, which
is the public default credential for the meshtastic.org MQTT broker rather
than a real secret. Suppress it with an explicit justification.
One of a series of small, independent lint cleanups that clear
trunk checkfailures. This PR contains a single commit.Written by Claude (Claude Code).
Summary by CodeRabbit