Skip to content

feat: New emoji 3 - #10930

Merged
thebentern merged 6 commits into
meshtastic:developfrom
Ixitxachitl:New-Emoji3
Jul 9, 2026
Merged

feat: New emoji 3#10930
thebentern merged 6 commits into
meshtastic:developfrom
Ixitxachitl:New-Emoji3

Conversation

@Ixitxachitl

@Ixitxachitl Ixitxachitl commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Add new emoji bitmaps and emote table entries for display on supported screens.

New emotes added:

  • Faces: 😃 Grinning Big Eyes, 🥶 Cold Face, 😩 Weary Face, 😮 Open Mouth, 😴 Sleeping Face, 👹 Ogre
  • Gestures: 🙌 Raising Hands
  • Symbols: 🗼 Tokyo Tower, 💯 Hundred Points, 📶 Antenna Bars
  • Weather: 🌅 Sunrise, 🌆 Sunset
  • Objects: ☕ Hot Beverage, 🍺 Beer, 🥔 Potato, 🪵 Wood, 💨 Dashing Away
  • Holidays: 🎄 Christmas Tree, 🎁 Wrapped Gift, 🕎 Menorah, ✝️ Latin Cross, ✡️ Star of David, ⛄ Snowman
  • Arrows: Added heavy arrow aliases (⬇️ ⬆️ ⬅️ ➡️) for all 4 cardinal directions
  • Rain: Added 🌧 alias without variation selector

All bitmaps are 16×16, stored in PROGMEM. No existing emotes were removed or modified.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Other: LilyGo T-Deck

Summary by CodeRabbit

  • New Features

    • Added many new emoji/emote options, including weather, holiday, gestures, symbols, objects, and extra face variants.
    • Expanded support for more arrow styles and alternate Unicode mappings.
    • Added new visible icons such as sunrise/sunset, hot beverage, beer, potato, wood, and several festive symbols.
  • Bug Fixes

    • Improved emoji coverage so more Unicode symbols now display as matching emotes.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: edfbf56f-d8b6-4d7d-93b5-a94640f8472f

📥 Commits

Reviewing files that changed from the base of the PR and between d16ae2b and ee9e0d8.

📒 Files selected for processing (2)
  • src/graphics/emotes.cpp
  • src/graphics/emotes.h

📝 Walkthrough

Walkthrough

This PR extends the emotes table in src/graphics/emotes.cpp with new Unicode-to-emote mappings spanning smileys, gestures, symbols, weather, holidays, and objects/arrows. Corresponding PROGMEM bitmap arrays are added for each new emote, with matching declarations added to src/graphics/emotes.h.

Changes

Emotes Table and Bitmap Expansion

Layer / File(s) Summary
Emotes table mapping additions
src/graphics/emotes.cpp
Adds new entries to the emotes table for smileys/alerts (antenna_bars), gestures/symbols (tower, one_hundred), weather (sunrise/sunset variants, rain), misc faces (ogre), and a large set of objects, arrows, and holidays (christmas_tree, wrapped_gift, menorah, latin_cross, star_of_david, snow_man, dashing_away, etc.).
Bitmap data and header declarations
src/graphics/emotes.cpp, src/graphics/emotes.h
Adds new PROGMEM bitmap arrays for all newly referenced emote IDs and adds matching *_width/*_height macros and extern const unsigned char [] PROGMEM; declarations in the header.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and does not clearly describe the emoji/emote additions in this PR. Rename it to clearly mention the new emoji/emote mappings and bitmap assets added in this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@github-actions github-actions Bot added the enhancement New feature or request label Jul 7, 2026
@Ixitxachitl
Ixitxachitl marked this pull request as ready for review July 7, 2026 17:44
@thebentern
thebentern merged commit faf92f6 into meshtastic:develop Jul 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants