fix: replace EVENT_CONTACT_FROM_PHONE for MUI keep awake - #10840
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughA single-line change in PacketAPI.cpp modifies the powerFSM trigger event used when receiving packets, replacing EVENT_CONTACT_FROM_PHONE with EVENT_INPUT. ChangesPowerFSM Event Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Contributor
⚡ Try this PR in the Web FlasherWarning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (25)
Build artifacts expire on 2026-07-31. Updated for |
thebentern
approved these changes
Jul 1, 2026
Contributor
Firmware Size Report22 targets | vs
Show 17 more target(s)
Updated for 1b5f593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #10571 breaks the previous MUI keep awake mechanism to tell the device not to sleep while MUI is being used.
This PR replaces (for MUI / PacketAPI) the previously used
EVENT_CONTACT_FROM_PHONE(which is in PhoneAPI actually used to keep the bluetooth connection alive while the phone is using it) byEVENT_INPUTto reset the screen/device sleep timer.🤝 Attestations
Summary by CodeRabbit