Skip to content

fix(FSCommon): add nRF52 LittleFS empty-name guard to getFiles() #10757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 4 commits into from
Jun 23, 2026
Merged

fix(FSCommon): add nRF52 LittleFS empty-name guard to getFiles() #10757

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a267fa
Initial plan
Copilot Jun 21, 2026
a3bd12f
fix(FSCommon): add file.name()[0] guard in getFiles() for nRF52 Littl…
Copilot Jun 21, 2026
57f0d0b
style(FSCommon): run clang-format (trunk fmt)
Copilot Jun 23, 2026
930bcae
Merge branch 'master' into copilot/fix-review-comment-3448366070
thebentern Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FSCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ std::vector<meshtastic_FileInfo> getFiles(const char *dirname, uint8_t levels)
return filenames;

File file = root.openNextFile();
while (file) {
while (file && file.name()[0]) { // file.name()[0] check is a workaround for a bug in the Adafruit LittleFS nrf52 glue (see issue 4395)
if (file.isDirectory() && !String(file.name()).endsWith(".")) {
if (levels) {
#ifdef ARCH_ESP32
Expand Down
Loading