QMP6988 env sensor support - #10273
Closed
mokjpn wants to merge 2 commits into
Closed
Conversation
|
|
Collaborator
|
Rather than changing protobufs directly here, please make a PR to https://github.com/meshtastic/protobufs with the protobuf changes. |
Author
|
Closing this in favor of a split protobufs/firmware flow. The protobuf enum addition has been moved to a separate PR: I will reopen the firmware-side change as a clean PR that depends on that protobuf update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds environmental telemetry support for the QMP6988 pressure sensor.
Changes included:
0x70and0x56QMP6988Sensortelemetry driverEnvironmentTelemetryNotes
During testing, some QMP6988 devices did not accept the reset command over this hardware path, but calibration readout and measurements still worked correctly. The driver now treats reset as optional and continues initialization when the sensor is otherwise responsive.
This PR is intended to add QMP6988 support only. It does not address unrelated SHT3x/SHT30 hardware address conflicts on specific boards.
Testing
Tested on:
Observed result:
Build tested:
pio run -e m5stack-unitc6l🤝 Attestations
Other: