Skip to content

QMP6988 env sensor support - #10273

Closed
mokjpn wants to merge 2 commits into
meshtastic:developfrom
mokjpn:codex/qmp6988-upstream
Closed

QMP6988 env sensor support#10273
mokjpn wants to merge 2 commits into
meshtastic:developfrom
mokjpn:codex/qmp6988-upstream

Conversation

@mokjpn

@mokjpn mokjpn commented Apr 23, 2026

Copy link
Copy Markdown

Summary

This PR adds environmental telemetry support for the QMP6988 pressure sensor.

Changes included:

  • add I2C detection for QMP6988 at 0x70 and 0x56
  • add a new QMP6988Sensor telemetry driver
  • register QMP6988 in EnvironmentTelemetry
  • add the telemetry sensor type for QMP6988
  • report temperature and barometric pressure in the same units used by the existing telemetry pipeline

Notes

During testing, some QMP6988 devices did not accept the reset command over this hardware path, but calibration readout and measurements still worked correctly. The driver now treats reset as optional and continues initialization when the sensor is otherwise responsive.

This PR is intended to add QMP6988 support only. It does not address unrelated SHT3x/SHT30 hardware address conflicts on specific boards.

Testing

Tested on:

  • Arduino Nesso N1
  • M5Stack Unit ENV III connected over Qwiic/Grove adapter

Observed result:

  • QMP6988 was detected successfully
  • initialization completed successfully
  • temperature and barometric pressure telemetry were reported correctly
  • pressure scaling was verified and corrected to hPa

Build tested:

  • pio run -e m5stack-unitc6l

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

Other:

  • Arduino Nesso N1 + M5Stack Unit ENV III

@CLAassistant

CLAassistant commented Apr 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added needs-review Needs human review hardware-support Hardware related: new devices or modules, problems specific to hardware labels Apr 23, 2026
@mokjpn mokjpn changed the title Codex/qmp6988 upstream QMP6988 env sensor support Apr 23, 2026
@jp-bennett

Copy link
Copy Markdown
Collaborator

Rather than changing protobufs directly here, please make a PR to https://github.com/meshtastic/protobufs with the protobuf changes.

@jp-bennett jp-bennett added the requires-protos Requires changes to protobufs to work label Apr 23, 2026
@mokjpn

mokjpn commented Apr 24, 2026

Copy link
Copy Markdown
Author

Closing this in favor of a split protobufs/firmware flow.

The protobuf enum addition has been moved to a separate PR:

I will reopen the firmware-side change as a clean PR that depends on that protobuf update.

@mokjpn mokjpn closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware-support Hardware related: new devices or modules, problems specific to hardware needs-review Needs human review requires-protos Requires changes to protobufs to work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants