upstream changes #11
Merged
upstream changes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logBuffer has logBufferMaxLines, the drawing needs to start shifted up by displayHeight % lineHeight so that the first line drops off a bit, and not the last. Now printing to display really just works. (I moved the `length++` and removed the `else` because both sides of the condition started with it.)
* Added drawLogBuffer(0,0) and display() at end of write() Now print, println and printf "just work", while display not refreshed every character when a string of characters is written, only at the end. * The assumption that chars are at most twice as high as they're wide was too optimistic * Remove the now unnecessary commands from DrawingDemo
There was no previous way for the user to empty the logBuffer, cls() fixes that. Also the documentation now explains the Print functionality and how it relates to the rest of the functions.
* logBuffer now stores max line length * write() rewritten to discard all but \n past that length * buffer cannot fill up prematurely * write() partly rewritten for clarity, no more re-entry when full
Explain where we deviate from what user might expect.
* setLogBuffer needs to be re-called (and past buffer cleared) every time a `setFont` happens, as this changes the number of lines and chars. It now does not take arguments anymore and does things internally and is clearer about when it gives up. * calculation of shiftUp for when on last line was wrong * setLogBuffer() and drawLogBuffer() old versions with arguments deprecated, new versions protected. * Made no-op setLogBuffer return true to pass compiler error
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.