fix: Fixing nodes long press & messages swiping

[ItsLimitlezz]

-This update prevents you from accidentally jumping to the nodes tab while scrolling in messages. now it only lets you jump to the nodes message when you click the message and not the gutter.
-It also disables long press on the nodes page for individual nodes. Now you press on the icon. the long press mixed with lag would mean a lot of times you would jump to a message with a node when just swiping.

Tested on T-Deck V2.7.19

[mverch67]

please remove all these .DS_Store binary files

[ItsLimitlezz]

All .DS_Store binary files have been deleted

[ItsLimitlezz]

Any updates? @mverch67

[Kealper]

Hoping this ends up making it in, this would go a very long way for daily-driver usability!

[t-miura]

hoping too, confirmed working with T-Deck Plus with firmware 2.7.24, device-ui with this patch!
while i haven't tested it with latest 2.7.25 yet, i might test as well on this weekends.

[ItsLimitlezz]

hoping too, confirmed working with T-Deck Plus with firmware 2.7.24, device-ui with this patch! while i haven't tested it with latest 2.7.25 yet, i might test as well on this weekends.

How did you like it?

[t-miura]

How did you like it?

in a single word: FANTASTIC!

more detailed(aka long poem):
No more accidental “jump to nodes list while swiping messages”.
I believe it never happened after applying your patches.

Before the patch, even swiping outside the message bubble (right side of the screen),
it would jump to the nodes list screen very often, which made me very frustrated.

However, now it’s so stable with no unwanted jumps, so the fix is working just right as you expected.
Also, the changes about how to actually jump to the node work fine, even feels more straightforward than before.

T-Deck Plus is (I think) my second node I got, and it’s the only one that runs device-ui/MUI in my fleet.
I wanted to utilize it as a standalone messenger, but that issue has been made myself away from actively using it.
Since whenever I try to swipe the message’s log, the jump happens. I've even worried if my unit is broken.
But now with your patch, it regained its position!

Thanks for the everything and hoping this'll get merged soon!

[ItsLimitlezz]

How did you like it?

in a single word: FANTASTIC!

more detailed(aka long poem): No more accidental “jump to nodes list while swiping messages”. I believe it never happened after applying your patches.

Before the patch, even swiping outside the message bubble (right side of the screen), it would jump to the nodes list screen very often, which made me very frustrated.

However, now it’s so stable with no unwanted jumps, so the fix is working just right as you expected. Also, the changes about how to actually jump to the node work fine, even feels more straightforward than before.

T-Deck Plus is (I think) my second node I got, and it’s the only one that runs device-ui/MUI in my fleet. I wanted to utilize it as a standalone messenger, but that issue has been made myself away from actively using it. Since whenever I try to swipe the message’s log, the jump happens. I've even worried if my unit is broken. But now with your patch, it regained its position!

Thanks for the everything and hoping this'll get merged soon!

@mverch67

[n30nex]

@mverch67
This works very nice, could you consider looking at this ?

[mverch67]

There are a couple of issue with this PR:

• several things that are not part of this PR have changed in code (e.g. node scrolling) without even mentioning
• I loaded this firmware and it crashed when creating the first new node and boots in a loop
• the changes made to the node panel are not compatible with keyboard control (i.e. long press is required)
• there are pixel offset constants implemented without considering the actual display size

Overall, while this specific PR may work for T-Deck users it may not work (and hasn't even been tested) for other devices (keyboard control, larger displays). I'm creating new PRs with some of the fixes of this PR which is more consistent across all supported devices.

[t-miura]

Thanks for the context!

Just to clarify, I wasn't the original author of this PR, I just tested it on my T-Deck Plus.
I really appreciate @ItsLimitlezz's hard work putting this together with some other challenges to fix other issues.

That said, I'm also agree with @mverch67's reasoning.
It makes perfect sense to apply a broader fix that benefits all device-ui capable devices,
as long as it doesn't introduce any new regressions.

I'm looking forward to seeing the new PR.
Whenever a new PR is ready, I'd be more than happy to help test it out on my T-Deck too!

[mverch67]

@t-miura @n30nex @ItsLimitlezz @Kealper: please help testing 🙏

I've created a new PR with a fundamental fix for T-Deck touch behavior.

For build and testing you need to comment the following line in variants/esp32s3/t-deck/platformio.ini:

and set the device-ui commit reference in platformio.ini to 9229227:

When testing please provide me a debug log (using tio /dev/ttyACM0) during the very first startup with the newly flashed firmware.