Fix missing tx_power and freq parameters for node configuration - #83
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughNode configuration creation now explicitly passes transmit power and frequency in both batch simulation setup and scenario file loading. ChangesRadio configuration propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the fix, looks good to me! |
Using both loraMesh.py and batchSim.py with the default invocation on the latest version could throw a similar TypeError for both files, as the required tx_power and freq arguments were not provided when creating a NodeConfig.
On loraMesh.py:
python3 loraMesh.py
TypeError: NodeConfig.from_gen_scenario_output() missing 2 required positional arguments: 'tx_power' and 'freq'
On batchSim.py:
python3 batchSim.py
TypeError: NodeConfig.init() missing 2 required positional arguments: 'tx_power' and 'freq'
This change adds the missing arguments to both files so NodeConfig objects can be created properly.
All tests pass after changes are made:
python -m unittest discover -s tests
Ran 31 tests in 2.988s
OK
Summary by CodeRabbit