-
-
Notifications
You must be signed in to change notification settings - Fork 279
feat(security): add packet authenticity policy aligned with Android #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
Meshtastic/Extensions/Protobufs/Config+PacketSignaturePolicy.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // | ||
| // Config+PacketSignaturePolicy.swift | ||
| // Meshtastic | ||
| // | ||
| // Display accessors for the firmware packet authenticity policy (design#121, protobufs#983). | ||
| // | ||
| // The labels and summaries are byte-identical to the Android/Desktop strings in | ||
| // `PacketAuthenticitySetting.kt` (Meshtastic-Android#6178) so the two clients describe the same | ||
| // device setting the same way. | ||
| // | ||
| // Terminology note: these say "authenticated"/"authentication" rather than "signed" because Strict | ||
| // accepts a packet authenticated *either* by a verified XEdDSA signature *or* by successful PKI | ||
| // decryption. "Signed" would wrongly imply authenticated PKI direct messages are rejected. | ||
| // | ||
|
|
||
| import Foundation | ||
| import MeshtasticProtobufs | ||
|
|
||
| extension Config.SecurityConfig.PacketSignaturePolicy { | ||
| /// The policies offered by the picker, weakest to strongest. `.UNRECOGNIZED` is never offered — | ||
| /// `pickerOptions(includingCurrent:)` appends it only when a device is already reporting it. | ||
| static let packetAuthenticityOptions: [Self] = [.compatible, .balanced, .strict] | ||
|
|
||
| /// Picker contents, guaranteed to contain `current`. | ||
| /// | ||
| /// SwiftUI pickers render incorrectly when the bound selection has no matching tag, so a device | ||
| /// on newer firmware reporting a policy this app version does not know must still be listed. | ||
| static func pickerOptions(includingCurrent current: Self) -> [Self] { | ||
| packetAuthenticityOptions.contains(current) | ||
| ? packetAuthenticityOptions | ||
| : packetAuthenticityOptions + [current] | ||
| } | ||
|
|
||
| var packetAuthenticityTitle: String { | ||
| switch self { | ||
| case .compatible: | ||
| return String(localized: "Compatible — Accept unsigned", comment: "Compatible packet authenticity policy option.") | ||
| case .balanced: | ||
| return String(localized: "Balanced — Prefer authenticated", comment: "Balanced packet authenticity policy option.") | ||
| case .strict: | ||
| return String(localized: "Strict — Require authentication", comment: "Strict packet authenticity policy option.") | ||
| case .UNRECOGNIZED: | ||
| return String(localized: "Unknown policy", comment: "Fallback title for an unrecognized packet authenticity policy.") | ||
| } | ||
| } | ||
|
|
||
| var packetAuthenticityDescription: String { | ||
| switch self { | ||
| case .compatible: | ||
| return String( | ||
| localized: "Authenticate packets when possible, but accept unsigned traffic for maximum compatibility.", | ||
| comment: "Description of the Compatible packet authenticity policy." | ||
| ) | ||
| case .balanced: | ||
| return String( | ||
| localized: "Recommended. Reject unsigned downgrade attempts from nodes known to sign.", | ||
| comment: "Description of the Balanced packet authenticity policy." | ||
| ) | ||
| case .strict: | ||
| return String( | ||
| localized: "Only show and process cryptographically authenticated mesh packets. Older nodes and oversized packets may disappear.", | ||
| comment: "Description of the Strict packet authenticity policy." | ||
| ) | ||
| case .UNRECOGNIZED: | ||
| return String( | ||
| localized: "This device reported a packet authenticity policy that this app version does not recognize.", | ||
| comment: "Description shown for an unrecognized packet authenticity policy." | ||
| ) | ||
| } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
Meshtastic/Extensions/SwiftData/SecurityConfigEntityExtension.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import SwiftData | ||
| import MeshtasticProtobufs | ||
|
|
||
| extension SecurityConfigEntity { | ||
| /// The persisted packet authenticity policy decoded back into its protobuf enum. | ||
| /// | ||
| /// `init?(rawValue:)` maps values this app version does not know to `.UNRECOGNIZED` rather than | ||
| /// `nil`, so a policy set by newer firmware survives a read/write round trip instead of being | ||
| /// silently reset to Compatible. | ||
| var storedPacketSignaturePolicy: Config.SecurityConfig.PacketSignaturePolicy { | ||
| Config.SecurityConfig.PacketSignaturePolicy(rawValue: Int(packetSignaturePolicy)) ?? .compatible | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.