Skip to content

fix(model): gate TAK module config on firmware 2.8.0 #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Jul 25, 2026
Merged

fix(model): gate TAK module config on firmware 2.8.0 #6435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions core/model/src/commonMain/kotlin/org/meshtastic/core/model/Capabilities.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,17 @@ data class Capabilities(val firmwareVersion: String?, internal val forceEnableAl
/** Support for Status Message module. Supported since firmware v2.8.0. */
val supportsStatusMessage = atLeast(V2_8_0)

/** Support for TAK (ATAK) module configuration. Supported since firmware v2.7.19. */
val supportsTakConfig = atLeast(V2_7_19)
/**
* Support for TAK (ATAK) module configuration. Gated to firmware v2.8.0.
*
* The v2.7.19 gate this replaces was set on protobuf availability rather than firmware support: v2.7.x
* `AdminModule::handleSetModuleConfig()` has no case for the `tak` submessage, so the node ACKs the write and
* reboots without storing anything, and `NodeDB::saveToDisk()` never sets `has_tak`. The editor therefore appeared
* to save and always read back as unspecified (Meshtastic-Android#6430).
*
* The firmware write, persist and remote-admin read paths land in meshtastic/firmware#11216, labelled for 2.8.
*/
val supportsTakConfig = atLeast(V2_8_0)

/**
* Support for the v2 TAK port (ATAK_PLUGIN_V2 = 78) with TAKPacketV2 + zstd dictionary compression. Supported since
Expand Down Expand Up @@ -94,7 +103,6 @@ data class Capabilities(val firmwareVersion: String?, internal val forceEnableAl
private val V2_6_10 = DeviceVersion("2.6.10")
private val V2_7_12 = DeviceVersion("2.7.12")
private val V2_7_18 = DeviceVersion("2.7.18")
private val V2_7_19 = DeviceVersion("2.7.19")
private val V2_8_0 = DeviceVersion("2.8.0")
private val UNRELEASED = DeviceVersion("9.9.9")
}
Expand Down
7 changes: 4 additions & 3 deletions core/model/src/commonTest/kotlin/org/meshtastic/core/model/CapabilitiesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,10 @@ class CapabilitiesTest {
}

@Test
fun supportsTakConfig_requires_V2_7_19() {
assertFalse(caps("2.7.18").supportsTakConfig)
assertTrue(caps("2.7.19").supportsTakConfig)
fun supportsTakConfig_requires_V2_8_0() {
assertFalse(caps("2.7.19").supportsTakConfig)
assertFalse(caps("2.7.26").supportsTakConfig)
assertTrue(caps("2.8.0").supportsTakConfig)
}

@Test
Expand Down
Loading