AB#1922 Fix: Validate resulting cardinality for to-one associations#201
Merged
Merged
Conversation
The association cardinality guard in GraphRuleEngine only checked the current DB state (currentMultiplicity == One), so a single mutation could add multiple targets to a to-one role (e.g. multiple parents on a TreeNode) when starting from an empty or already-corrupt state. ValidateOrigin and ValidateTarget now validate the resulting cardinality after applying the batch: a violation is reported when a to-one role net-adds while already One/Many, or creates two or more from Zero. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mmgerald
added a commit
that referenced
this pull request
Jun 30, 2026
…ts-cardinality AB#1922 Fix: Validate resulting cardinality for to-one associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParentChildoutboundParent, multiplicityOne).GraphRuleEnginechecked only the current DB state (currentMultiplicity == One) instead of the resulting cardinality after applying the batch. A single mutation creating ≥2 targets from an empty state (Zero) slipped through.ValidateOriginandValidateTarget: report a violation when a to-one role net-adds while alreadyOne/Many, or creates two or more fromZero.Azure DevOps Work Item
AB#1922
Test Plan
🤖 Generated with Claude Code