Skip to content

Conversation

AuraReaper
Copy link

@AuraReaper AuraReaper commented Sep 18, 2025

Description
This PR fixes meshery/meshery#15021

Notes for Reviewers

This PR is part of a multi-repo change to add a createdAt timestamp to model metadata. It depends on the changes in the schemas repository PR linked below.

This change updates the meshkit repository to populate the new createdAt field in the model metadata.

Changes:

  • Updated all locations where ModelDefinition_Metadata is created to populate the createdAt field.

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Sep 18, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AuraReaper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a createdAt timestamp into model metadata within the meshkit repository. This change is part of a broader, multi-repository effort to standardize the inclusion of creation timestamps for model definitions. By populating this field at the point of model metadata initialization, the PR ensures that all model definitions are consistently stamped with their creation time, improving data consistency and providing a historical record for each model.

Highlights

  • Populate createdAt in Model Metadata: The createdAt timestamp is now consistently populated in ModelDefinition_Metadata across various locations where model metadata is initialized or updated. This ensures that all model definitions include a creation timestamp, enhancing data traceability.
  • Dependency Update: The go.mod and go.sum files have been updated to reflect a minor version bump for the oapi-codegen/runtime dependency from v1.1.1 to v1.1.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consistently populates the createdAt field in ModelDefinition_Metadata across various parts of the codebase, which is a good enhancement for tracking model creation. The implementation is correct in all instances. My main feedback is to address the code duplication for metadata initialization by introducing a constructor function in the meshery/schemas repository. This would improve long-term maintainability.

@AuraReaper
Copy link
Author

This PR's depends on the changes made in the schema repo so i think that should be merged first in-order for changes in this repo to take place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding created_at/added field inside the registry model metadata

2 participants