Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection APIs for local provider #11023

Conversation

Yashsharma1911
Copy link
Contributor

Notes for Reviewers

This PR fixes #

I was getting issues on last, PR that's why I created this new PR with new changes

Signed commits

  • Yes, I signed my commits.

Copy link

github-actions bot commented May 23, 2024

@leecalcote leecalcote added the pr/draft WIP/Draft pull request label May 23, 2024
@leecalcote
Copy link
Member

Remove draft label when utility is being used.

@Yashsharma1911
Copy link
Contributor Author

Screen.Recording.2024-05-28.at.6.53.39.PM.mov

@Yashsharma1911 Yashsharma1911 removed the pr/draft WIP/Draft pull request label May 29, 2024
server/models/default_local_provider.go Show resolved Hide resolved
server/models/default_local_provider.go Show resolved Hide resolved
server/models/default_local_provider.go Show resolved Hide resolved
server/helpers/utils/utils.go Show resolved Hide resolved
@Yashsharma1911
Copy link
Contributor Author

This PR is done already, after approval we should be good to merge if there is no other review, I'll create an new issue to define connection schema and use it, I think currently we only using schema reference for models and components right @MUzairS15 ?

@MUzairS15
Copy link
Contributor

Connection schema is ready defined, what else are you referring to?

@Yashsharma1911
Copy link
Contributor Author

Connection schema is ready defined, what else are you referring to?

I was looking at this file https://github.com/meshery/schemas/blob/master/schemas/constructs/v1alpha2/connection.yml, is this correct location to check connection schema? this is openAPI schema

@leecalcote
Copy link
Member

@Yashsharma1911 @MUzairS15 we're in need of creating and releasing golang package(s) from this repo.

@leecalcote
Copy link
Member

@Yashsharma1911 @MUzairS15 it's time - meshery/schemas#43

@MUzairS15
Copy link
Contributor

Connection schema is ready defined, what else are you referring to?

I was looking at this file https://github.com/meshery/schemas/blob/master/schemas/constructs/v1alpha2/connection.yml, is this correct location to check connection schema? this is openAPI schema

Yes, this is correct

@MUzairS15
Copy link
Contributor

@Yashsharma1911 @MUzairS15 we're in need of creating and releasing golang package(s) from this repo.

Yes.👍

@leecalcote
Copy link
Member

Please fix merge conflicts.

@leecalcote
Copy link
Member

Please fix merge conflicts.

Please fix merge conflicts, @Yashsharma1911

@Yashsharma1911
Copy link
Contributor Author

Yashsharma1911 commented Jul 24, 2024

Merge conflicts resolved, considering this is high issue for now I'm moving with this PR

@Yashsharma1911 Yashsharma1911 merged commit 898eade into meshery:master Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants