Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken image. #373

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix broken image. #373

merged 1 commit into from
Sep 28, 2022

Conversation

NPDebs
Copy link
Contributor

@NPDebs NPDebs commented Sep 27, 2022

Signed-off-by: Deborah Udoh [email protected]

Description
This PR fixes issue #371

readme-img

Notes for Reviewers
The broken image was fixed by editing line 34, to change the file format (from SVG to PNG). Thank you.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Deborah Udoh <[email protected]>
@NPDebs NPDebs marked this pull request as ready for review September 27, 2022 18:11
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @NPDebs

@leecalcote leecalcote merged commit 986fe3e into meshery:master Sep 28, 2022
@leecalcote
Copy link
Member

@NPDebs, oh, I just noticed that there are two sets of the community images. Will you take a look at the other repos’ readmes and make this one similar?

@NPDebs
Copy link
Contributor Author

NPDebs commented Sep 28, 2022

Sure Mr @leecalcote . Right away. 🏃🏽‍♀️💨

@NPDebs
Copy link
Contributor Author

NPDebs commented Sep 28, 2022

Wow. I see the error of my ways. Only one image shows up in the other repos.

I've made the necessary changes on my fork. Opening a new PR now... || @leecalcote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants