-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo updated to meshery from layer5 #576
Conversation
Signed-off-by: Vivek jha <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duckling69 Please check the path for the image source.
.github/config.yml
Outdated
![Congrats!](https://raw.githubusercontent.com/meshery/meshery-istio/master/.github/welcome/Layer5-celebration.png) | ||
|
||
<picture> | ||
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Meshery-darkmode-celebration.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Meshery-darkmode-celebration.svg"> | |
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-istio/master/.github/welcome/Meshery-darkmode-celebration.svg"> |
.github/config.yml
Outdated
@@ -17,8 +17,11 @@ newPRWelcomeComment: > | |||
firstPRMergeComment: > | |||
Thanks for your contribution to the Layer5 community! :tada: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to the Layer5 community! :tada: | |
Thanks for your contribution to Meshery! :tada: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the image files to lowercase file names.
Signed-off-by: Vivek jha <[email protected]>
…tion.svg Signed-off-by: Vivek jha <[email protected]>
…on.svg Signed-off-by: Vivek jha <[email protected]>
@goldfishdolphin @thisiskaransgit done with all reviewed changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, thank you for your contribution 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job @duckling69!
Thank you for your contribution.
Thanks for your contribution to the Meshery! 🎉 |
Description
This PR fixes issue #568
Notes for Reviewers
Signed commits