Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo updated to meshery from layer5 #576

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

duckling69
Copy link
Contributor

Description

This PR fixes issue #568

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented May 8, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote leecalcote added the area/docs Improvements or additions to documentation label May 8, 2023
Copy link
Member

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duckling69 Please check the path for the image source.

![Congrats!](https://raw.githubusercontent.com/meshery/meshery-istio/master/.github/welcome/Layer5-celebration.png)

<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Meshery-darkmode-celebration.svg">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Meshery-darkmode-celebration.svg">
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-istio/master/.github/welcome/Meshery-darkmode-celebration.svg">

@@ -17,8 +17,11 @@ newPRWelcomeComment: >
firstPRMergeComment: >
Thanks for your contribution to the Layer5 community! :tada:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanks for your contribution to the Layer5 community! :tada:
Thanks for your contribution to Meshery! :tada:

Copy link
Member

@goldfishdolphin goldfishdolphin May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the image files to lowercase file names.

@duckling69
Copy link
Contributor Author

@goldfishdolphin @thisiskaransgit done with all reviewed changes

Copy link

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thank you for your contribution 🎉

Copy link
Member

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @duckling69!
Thank you for your contribution.

@theBeginner86 theBeginner86 merged commit c854864 into meshery:master Jun 9, 2023
@welcome
Copy link

welcome bot commented Jun 9, 2023

Thanks for your contribution to the Meshery! 🎉

Meshery Celebration logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants