-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: MeshWorks and Patternfiles #34
Conversation
Signed-off-by: Utkarsh Srivastava <[email protected]>
Signed-off-by: Utkarsh Srivastava <[email protected]>
Signed-off-by: Utkarsh Srivastava <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may some advice please kindly check the comments
@leecalcote @Utkarsh-pro Could you guys write more detail about this feature? |
Hi @Aisuko, yes, good request. Here we are - https://docs.google.com/document/d/1B2N78EdRiZF-yVo1-HY3syppwBBDumgMuYg6seD-AJ4/edit |
Signed-off-by: Utkarsh Srivastava <[email protected]>
@Utkarsh-pro lets make a meshkit release to have proper versioning. We don't wanna stick to branch. |
@Utkarsh-pro out of interest: why are there 2 |
@mgfeller new versions of protoc compiler spit out two files (if generating for grpc). One if the file is solely responsible for proto files serialization and deserialization while the other file contains the code for grpc (like implementing methods, interfaces etc.). We don't have to change the makefile in my opinion, the new protoc will handle that automatically for us. |
@Utkarsh-pro thanks for the feedback. Referring to meshery/meshery#2454, I had to install the latest plugin according to https://grpc.io/docs/languages/go/quickstart/ (I was probably using the github version superseded by this one). I had to update the Makefile as well: |
Description
New feature support of MeshWorks and Patternfiles
Signed commits