Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version and remove no useful tracing code #137

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Oct 27, 2023

Description

This PR fixes #125

Notes for Reviewers

  • Bump version of Go to v1.21
  • Bump version of meshkit to v0.6.77
  • Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.45.0
  • Bump the version of github.com/grpc-ecosystem/go-grpc-middleware/v2 to the stable version v2.0.1

And remove the no useful tracing features. It imported go.opentelemetry.io different version with go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. And the one of the reasons here is that go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc didn't update the go.opentelemetry.io version yet. And there is no any other adapters are using tracing feature. So, removing it.

Removing tracing feature can also cause breaking change of grpc Start function.

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko self-assigned this Oct 27, 2023
@Aisuko Aisuko added the language/go Golang related label Oct 27, 2023
@Aisuko Aisuko merged commit aab8a58 into master Oct 27, 2023
2 checks passed
@Aisuko Aisuko deleted the feat/bumpgo branch October 27, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] update Go to 1.21, and update relevant pkgs
1 participant