Basic gps support for Heltec_v3 and T1000e - #91
Closed
fdlamotte wants to merge 2 commits into
Closed
Conversation
Contributor
|
Can the same enhancement also be applied to the Heltec V2 variant please? (Please don't forget about the V2s - there are a lot out there ;-) ) |
fkallay1
added a commit
to fkallay1/MeshCore
that referenced
this pull request
Jun 18, 2026
…flash base z linker symbolu RAM-assembly refaktor (rieši 2× FS pri veľkých patchoch): - ota_acquire_patch_ram(): patch do čerstvo malloc-nutého RAM buffra; default zostaví z recv.log (assemble_log_to_buf: build_log_offsets + chunk_exp_len), -D USE_PATCHBIN_FILE číta /ota/patch.bin. Caller free(). - assemble_and_verify() pri COMPLETE: default verify_log_sha() = SHA256 streamovo z recv.log (žiadny patch.bin, žiadny veľký buffer); USE_PATCHBIN_FILE = patch.bin + over + zmaž recv.log (cleanup, rieši 2× v file móde). - dry-run (ota_patch_to_file) aj real (ota_flash_via_flasher) cez ota_acquire_patch_ram → puff_stream / MemStream nad RAM buffrom. patch_file_read ostal unused. - malloc zlyhanie = graceful error s tipom na -D USE_PATCHBIN_FILE. Tier-2 (deštruktívny assemble do 0x20000000) NEIMPLEMENTOVANÝ (risk/netestovateľné). fw_image_size(): base z linker symbolu __flash_arduino_start (= ORIGIN(FLASH)) namiesto hardcoded APP_FLASH_START → robustné pre v6/v7. Tvrdý symbol (žiadny weak fallback) — ak chýba (non-Arduino projekt), link error = fail-fast, zámerne. APP_FLASH_START/MAX makrá ostávajú pre compile-time kontexty. E2E PASS na HW: build meshcore-dev#90→meshcore-dev#91, dry-run aj real flash z recv.log→RAM, dry-run pred flashom bez hardfaultu. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dl9sau
pushed a commit
to dl9sau/MeshCore-fork-DL9SAU
that referenced
this pull request
Jul 16, 2026
…meshcore-dev#91) '#unscoped' kam spaeter (send-seitig einpraegsamer Alias) dazu, wurde aber nie in die Region-Registry eingetragen (die scope info/findScopeByName abfragt) -- korrekt so, denn unscoped ist KEIN keyed Scope, sondern das Fehlen eines Scopes. 'scope info unscoped' sagte daher '#unscoped nicht bekannt'. Jetzt: synthetischer Spezialfall mit erklaerender Info, ohne unscoped faelschlich als keyed Region zu registrieren. Kein 'no-scope' (vom User nicht gewuenscht). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a basic implementation, tried to be as generic as possible ...
works on t1000e and HeltecV3, disabled if HAS_GPS is not defined