Allow companion BLE/USB CMD_SET_DEVICE_TIME to set clock backwards - #3195
Open
estebanscdev wants to merge 1 commit into
Open
Allow companion BLE/USB CMD_SET_DEVICE_TIME to set clock backwards#3195estebanscdev wants to merge 1 commit into
estebanscdev wants to merge 1 commit into
Conversation
CMD_SET_DEVICE_TIME only ever arrives from the locally-paired companion app/CLI, not from untrusted mesh peers, so the owner should be able to correct a drifted device clock in either direction. Previously a fast- running clock (e.g. software fallback clock on nRF52 boards with no GPS fix or RTC chip, after long uptime) could never be corrected once it drifted ahead, since the firmware rejected any earlier timestamp. Fixes meshcore-dev#3173
|
Thanks for this modification. I hope that it will be accepted because it really solves a headache. My client always checks the time at startup and tries to correct it if it is more off than 10 seconds. But this never works due to the restriction of not being able to set an earlier time. I can see some logic in this rule but I think that it makes overall more sense to allow to set any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMD_SET_DEVICE_TIME only ever arrives from the locally-paired companion app/CLI, not from untrusted mesh peers, so the owner should be able to correct a drifted device clock in either direction. Previously a fast- running clock (e.g. software fallback clock on nRF52 boards with no GPS fix or RTC chip, after long uptime) could never be corrected once it drifted ahead, since the firmware rejected any earlier timestamp.
Fixes #3173