fix: fix typos in source code comments - #2639
Merged
Merged
Conversation
Contributor
|
Duplicate of #2619 |
Member
Looks like that one has merge conflicts, and touches external embedded libs. I'll merge this one instead for now. |
Contributor
Author
|
Thanks ^^ |
hermes-gadget
added a commit
to gadgethd/MeshCore-MQTT
that referenced
this pull request
Jun 27, 2026
Upstream dev: 3d4eec4..5ff39c6 (10 commits) - Merge PR meshcore-dev#2570: fix flash mode XiaoC6 - Merge PR meshcore-dev#2639: fix typos in comments - Merge PR meshcore-dev#2844: fix rx boosted gain - always save boosted gain setting - fix: report error when rxgain setting is unsupported/rejected - return bool when setting rx boost - remove guard on MyMesh::setRxBoostedGain() - fix: fix typos in source code comments (x2) - Added flash_mode=dio to avoid boot loop on merge.bin flash Integration work: - Resolved CommonCLI.cpp conflict: kept packPrefs/unpackPrefs architecture (upstream didn't touch CommonCLI.h in this window, --theirs was sufficient) - Squash merge of origin/main (all MQTT additions preserved) - Removed firmware binaries from webflasher/ - Added gitignore patterns All MQTT additions preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/helpers/stm32/InternalFileSystem.cpp:propogated→propagated(3 occurrences)src/Mesh.h:hashes if each repeater→hashes of each repeatersrc/helpers/ui/OLEDDisplay.cpp:Code form http://→Code from http://,depnding→dependingsrc/helpers/bridges/ESPNowBridge.cpp:Set wifi channel→Set Wi-Fi channelexamples/companion_radio/DataStore.cpp:oldest timestmap→oldest timestamp