Skip to content

sensecap_solar: Fixing LED definitions - #1689

Merged
liamcottle merged 1 commit into
meshcore-dev:devfrom
aXistem-dev:feature/sensecap-led-fix
Mar 7, 2026
Merged

sensecap_solar: Fixing LED definitions#1689
liamcottle merged 1 commit into
meshcore-dev:devfrom
aXistem-dev:feature/sensecap-led-fix

Conversation

@Confituurke

Copy link
Copy Markdown
Contributor

Summary

Corrects the LED pin definitions for the SenseCap Solar P1 to match the actual hardware. The blue LoRa TX LED was incorrectly named green in the code, and the user LED is white (not blue).

Problem

  • User LED (D11) – White LED on pin 11 was defined as LED_GREEN on pin 12
  • LoRa TX LED (D12) – Blue LED on pin 12 was defined as LED_BLUE on pin 11

Changes

  • LED_GREEN (12) → LED_WHITE (11) – User LED on D11
  • LED_BLUE (11) → LED_BLUE (12) – LoRa TX indicator on D12

Hardware mapping

Pin Function Define
D11 (P0.15) User LED (white) LED_WHITE
D12 (P0.19) LoRa TX / breathing LED (blue) LED_BLUE

@Confituurke Confituurke changed the title sensecap_solar: Simple fix LED definitions sensecap_solar: Fixing LED definitions Feb 20, 2026
@Confituurke

Copy link
Copy Markdown
Contributor Author

@liamcottle @recrof
Could you check and eventually approve this PR, this fixes LED assignment and naming in the code.
PINs where wrongly assigned/swapped. + Green LED is in fact a White LED. The actual Green LED on the SenseCAP Solar cannot be used via a PIN and is used to indicate the battery state.

Thank you in advance.

@Confituurke
Confituurke force-pushed the feature/sensecap-led-fix branch from b2f1dd6 to 5188221 Compare March 7, 2026 09:17
@liamcottle
liamcottle merged commit 5ac8ab2 into meshcore-dev:dev Mar 7, 2026
9 checks passed
@Confituurke
Confituurke deleted the feature/sensecap-led-fix branch March 7, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants