Fix binary STL loading following switch from msgpack-lite to msgpack-javascript #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon Unclear why we need to specialise this type since the switch from msgpack-lite to msgpack - but without it the geometries do not get decoded.
|
Thanks for this. The backstory is that When this code switched its msgpack library (#132), only two extension types ( I'll work on cleaning up the whole program, and making sure the test cases catch it. |
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the switch to msgpack-javascript from msgpack-lite (#132), we were no longer able to load binary STL meshes via meshcat-python: When decoding the message, it would leave the
decoded.geometries[i].dataas an object (with type and raw data) rather than the decoded array.Specialising the decoder for Uint8Array as well resolves this. It's a bit of a mystery to me why it did not decode it out of the box, so any insights (or better solutions) much appreciated :-)