Skip to content

fix(block): respect current config when sanitizing labels #7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishjain0512 merged 2 commits into from
Jun 1, 2026
Merged

fix(block): respect current config when sanitizing labels #7674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc75089
fix(block): use current config for label sanitization
cyphercodes Apr 27, 2026
56d2b45
Merge remote-tracking branch 'origin/develop' into bug/7622_block-san…
ashishjain0512 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-block-sanitize-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'mermaid': patch
---

fix(block-beta): respect current DOMPurify config when sanitizing labels
13 changes: 13 additions & 0 deletions packages/mermaid/src/diagrams/block/parser/block.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
// @ts-ignore: jison doesn't export types
import block from './block.jison';
import db from '../blockDB.js';
import * as configApi from '../../../config.js';
import { log } from '../../../logger.js';

describe('Block diagram', function () {
describe('when parsing a block diagram graph it should handle > ', function () {
beforeEach(function () {
configApi.setSiteConfig({});
configApi.reset();
block.parser.yy = db;
block.parser.yy.clear();
block.parser.yy.getLogger = () => console;
Expand Down Expand Up @@ -34,6 +37,16 @@ describe('Block diagram', function () {
expect(blocks[0].label).toBe('A label');
expect(blocks[0].type).toBe('square');
});
it('sanitizes labels with the current dompurify config', () => {
configApi.setSiteConfig({ dompurifyConfig: { FORBID_TAGS: ['b'] } });
const str = `block
id["<b>Bold</b>"]
`;

block.parse(str);
const blocks = db.getBlocks();
expect(blocks[0].label).toBe('Bold');
});
it('a diagram with multiple nodes', () => {
const str = `block
id1
Expand Down
Loading