Skip to content

5460 - Initial Release for review - #5461

Closed
darkedges wants to merge 2 commits into
mermaid-js:developfrom
darkedges:feature/5460-addingMarkdownToSequenceDiagramNotes
Closed

darkedges wants to merge 2 commits into
mermaid-js:developfrom
darkedges:feature/5460-addingMarkdownToSequenceDiagramNotes

Conversation

@darkedges

Copy link
Copy Markdown

#5460
This adds Markdown support for SequenceDiagram notes Needs cleanup.

📑 Summary

This adds Markdown support for notes and syntax highlighting.

Resolves #5460

📏 Design Decisions

Updates the Parser to include support dor multline end support.
Detects if it fins Markdown and uses the Markdown renderer to geneate text.
Follows the same pattern as katexsupport.

📋 Tasks

Make sure you

mermaid-js#5460
This adds Markdown support for SequenceDiagram notes
Needs cleanup.
@github-actions github-actions Bot added the Type: Enhancement New feature or request label Apr 13, 2024
@netlify

netlify Bot commented Apr 13, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit ecfe14a
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661d96848e8c4d000859a8b7
😎 Deploy Preview https://deploy-preview-5461--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@darkedges

Copy link
Copy Markdown
Author

I need some help cleaning up the parser as that is currently breaking checkins.

Conflict in grammar: multiple actions possible when lookahead token is TXT in state 116
- reduce by rule: note_section -> 
- shift token (then go to state 120)

States with conflicts:
State 116
  note_statement -> note placement actor .text2 #lookaheads= NEWLINE
  note_statement -> note placement actor .note_section end #lookaheads= NEWLINE
  text2 -> .TXT
  note_section -> . #lookaheads= end ACTOR TXT NEWLINE
  note_section -> .note_section note_line #lookaheads= end ACTOR TXT NEWLINE
Conflict in grammar: multiple actions possible when lookahead token is TXT in state 116
- reduce by rule: note_section ->
- shift token (then go to state 120)

States with conflicts:
State 116
  note_statement -> note placement actor .text2 #lookaheads= NEWLINE
  note_statement -> note placement actor .note_section end #lookaheads= NEWLINE
  text2 -> .TXT
  note_section -> . #lookaheads= end ACTOR TXT NEWLINE
  note_section -> .note_section note_line #lookaheads= end ACTOR TXT NEWLINE

also need to include the css requied for highligthing.

@knsv-bot

knsv-bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @darkedges — thanks for taking a run at adding Markdown to sequence-diagram notes (#5460). This stalled at the grammar-conflict stage and hasn't moved since, and in the meantime the effort has been carried forward elsewhere (see #5705 and the broader work to migrate string handling onto the shared markdown approach). Rather than leave a branch that doesn't build, I'm going to close this. The feature itself is still wanted — #5460 remains open — and that migration is where it'll ultimately land. Thanks for the effort! 🙇

@knsv knsv closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding Markdown to SequenceDiagram Notes

3 participants