Repository navigation
Conversation
mermaid-js#5460 This adds Markdown support for SequenceDiagram notes Needs cleanup.
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
I need some help cleaning up the parser as that is currently breaking checkins. also need to include the |
Collaborator
|
Hi @darkedges — thanks for taking a run at adding Markdown to sequence-diagram notes (#5460). This stalled at the grammar-conflict stage and hasn't moved since, and in the meantime the effort has been carried forward elsewhere (see #5705 and the broader work to migrate string handling onto the shared markdown approach). Rather than leave a branch that doesn't build, I'm going to close this. The feature itself is still wanted — #5460 remains open — and that migration is where it'll ultimately land. Thanks for the effort! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5460
This adds Markdown support for SequenceDiagram notes Needs cleanup.
📑 Summary
This adds Markdown support for notes and syntax highlighting.
Resolves #5460
📏 Design Decisions
Updates the Parser to include support dor multline end support.
Detects if it fins Markdown and uses the Markdown renderer to geneate text.
Follows the same pattern as katexsupport.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch