#1092 Fix for mangling of multiple classDiagrams #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knsv
approved these changes
Jan 8, 2020
|
Thanks! We had one user run into this. @knsv Would you mind cutting a new release with these changes? |
|
I dont mind at all. It will happen this weekend. |
|
@knsv @chris579 Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Fixes rendering of multiple class diagrams on the same page.
Also, Handles click event for multiple class diagrams use-case.
Resolves #1092
📏 Design Decisions
Separation of DOM id and class Id in graph definition.
📋 Tasks
Make sure you
developbranch