Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Handle multiline section titles in gantt diagrams #1188

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Feature/Handle multiline section titles in gantt diagrams #1188

merged 2 commits into from
Jan 8, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Jan 8, 2020

📑 Summary

Enhanced gantt renderer to handle multiline texts in section titles.

Resolves #743

📏 Design Decisions

Split up the texts and appended tspan elements for the lines.
Modified y position according to number of text lines in the titles.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@ashishjain0512
Copy link
Collaborator

@GDFaber Good Job !!

@ashishjain0512 ashishjain0512 merged commit 1820458 into mermaid-js:develop Jan 8, 2020
@GDFaber GDFaber deleted the feature/743_gantt_multiline_section_titles branch January 8, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gantt: syntax for multi-line section titles?
2 participants