Feature/issue 1146 dashed line for class diagram #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishjain0512
added
Type: Enhancement
jgreywolf
approved these changes
Jan 3, 2020
@jgreywolf Yes, that is correct. JISON was parsing relation line type as solid or dash but was not rendering it properly. This PR fixes that and allows proper rendering for dependency, realization relation type between classes. This has been updated in the documentation for the class diagram also. |
klemmchr
approved these changes
Jan 3, 2020
ashishjain0512
deleted the
feature/Issue-1146_Dashed_Line_For_Class_Diagram
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This PR adds dashed-line support for class diagram relations like dependency, realization, etc.
Resolves #1146
📏 Design Decisions
Implementation follow similar JISON format like other relation definition, no changes in JISON. Make use of the relation line type which can be solid or dashed.
📋 Tasks
Make sure you
developbranch