Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1154 Flow diagram DB shape request #1166

Merged
merged 1 commit into from
Jan 1, 2020
Merged

#1154 Flow diagram DB shape request #1166

merged 1 commit into from
Jan 1, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Dec 31, 2019

📑 Summary

Added cylindric node shape to flowchart implementation.

Resolves #1154

📏 Design Decisions

  • Used syntax [(...)] for cylindric nodes.
  • Used SVG path for cylindric visualisation.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

knsv
knsv approved these changes Jan 1, 2020
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God job! I appreciate the extra effort with unit tests, integration tests and docs!

@knsv knsv merged commit 75e2abe into mermaid-js:develop Jan 1, 2020
@GDFaber GDFaber deleted the feature/flowchart_add_cylindric_shape branch January 7, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow diagram DB shape request
2 participants
@GDFaber @knsv