Skip to content

9.3.0#1119

Merged
sidharthv96 merged 14 commits into
developfrom
release/9.3
Dec 15, 2022
Merged

9.3.0#1119
sidharthv96 merged 14 commits into
developfrom
release/9.3

Conversation

@sidharthv96

Copy link
Copy Markdown
Member

📑 Summary

Brief description about the content of your PR:

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify

netlify Bot commented Dec 9, 2022

Copy link
Copy Markdown

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 860039a
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/639b09945b0a3b000875fd04
😎 Deploy Preview https://deploy-preview-1119--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress

cypress Bot commented Dec 9, 2022

Copy link
Copy Markdown



Test summary

26 0 6 0


Run details

Project Mermaid Live Editor
Status Passed
Commit 1259bd7 ℹ️
Started Dec 15, 2022 11:50 AM
Ended Dec 15, 2022 11:52 AM
Duration 02:50 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sidharthv96 sidharthv96 changed the title 9.3.0-rc.1 9.3.0 Dec 12, 2022
@sidharthv96

sidharthv96 commented Dec 14, 2022

Copy link
Copy Markdown
Member Author

@aloisklink @tbo47 any pointers on what the issue might be?
Unit test passes in my machine, but fails in CI with dagre-es issue.

@aloisklink

Copy link
Copy Markdown
Member

@aloisklink @tbo47 any pointers on what the issue might be?
Unit test passes in my machine, but fails in CI with dagre-es issue.

This should be fixed by tbo47/dagre-es#12. This issue is that vitest/node requires the file extension in ESM imports (something in mermaid probably automatically adds them, maybe it's TypeScript).

You can test this fix by adding the following to your package.json file.

  "resolutions": {
    "dagre-d3-es": "git+https://github.com/aloisklink/dagre-es#fix-esm-imports"
  }

@tbo47

tbo47 commented Dec 14, 2022

Copy link
Copy Markdown

do you need a new release?

@tbo47

tbo47 commented Dec 14, 2022

Copy link
Copy Markdown

I guess you do. So I'll make one lol

@tbo47

tbo47 commented Dec 14, 2022

Copy link
Copy Markdown

Let me know if 7.0.6 fixes you problem.

@sidharthv96

Copy link
Copy Markdown
Member Author

@aloisklink @tbo47 It did fix it!!
Thanks a lot folks 🚀

@sidharthv96 sidharthv96 merged commit cc7411f into develop Dec 15, 2022
@sidharthv96 sidharthv96 deleted the release/9.3 branch December 15, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants