Streaming changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unnecessary verbose fields "script_asm" and "script_hex"
add missing ','
taproot testing from upstream
re-appended more fixes for taproot from upstream (rather merged) PR blockchain-etl#57
akshay-ghy
reviewed
Aug 29, 2022
| BITCOIN_GOLD = 'bitcoin_gold' | ||
| DOGECOIN = 'dogecoin' | ||
| LITECOIN = 'litecoin' | ||
| DASH = 'dash' | ||
| ZCASH = 'zcash' | ||
| MONACOIN = 'monacoin' | ||
|
|
||
| ALL = [BITCOIN, BITCOIN_CASH, BITCOIN_GOLD, DOGECOIN, LITECOIN, DASH, ZCASH, MONACOIN] | ||
| ALL = [BITCOIN, BITCOIN_CASH, BITCOIN_CASH_SV, BITCOIN_GOLD, DOGECOIN, LITECOIN, DASH, ZCASH, MONACOIN] | ||
| # Old API doesn't support verbosity for getblock which doesn't allow querying all transactions in a block in 1 go. | ||
| HAVE_OLD_API = [BITCOIN_CASH, DOGECOIN, DASH, MONACOIN] |
There was a problem hiding this comment.
should we check if they support verbosity for these chains now?
akshay-ghy
reviewed
Aug 29, 2022
| @@ -178,6 +167,8 @@ def _remove_coinbase_input(self, block): | |||
| def _add_non_standard_addresses(self, transaction): | |||
| for output in transaction.outputs: | |||
| if output.addresses is None or len(output.addresses) == 0: | |||
| # output.type = 'nonstandard' | |||
| # if output.type != 'multisig': | |||
aknirmal90
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.