Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashrom_rpi scripts: choose a chip automatically #26

Closed
merge opened this issue May 17, 2018 · 1 comment
Closed

flashrom_rpi scripts: choose a chip automatically #26

merge opened this issue May 17, 2018 · 1 comment
Labels
enhancement

Comments

@merge
Copy link
Owner

merge commented May 17, 2018

I'm thinking about finding heuristics, that would choose a working flashrom chip for us. We could:

  • run flashrom -p ... &> temp_flashrom.txt
  • cat temp_flashrom.txt | grep <chip> and save if found
  • 4m/8m are seperate anyways, but in what order to check for which chips?
  • if found, continue instead of requiring the -c commandline option.
merge added a commit that referenced this issue May 17, 2018
@merge
x230: flashrom scripts: add -a option for autodetecting the chip
6791931 
This adds an experimental option to choose a chip from flashrom's list
using our own heuristics. If successful this should become the default
behaviour when when "-c" is not specified.

Basically this should completely replace the documentation section
"flashrom chip config" at some point.

Adresses issue #26
@merge merge mentioned this issue May 17, 2018
Closed
@merge
Copy link
Owner Author

merge commented May 17, 2018 •
edited
Loading

current logic for the 8m:

  • if "MX25L6406E/MX25L6408E" is in the list, take it. if not:
  • if "EN25QH64" is in the list, take it.

and for the 4m:

  • if "MX25L3206E" is in the list, take it.

could we do better?

@merge merge closed this as completed in 4a50b33 May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merge