Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1 #2

Merged
merged 1 commit into from
Feb 11, 2022
Merged

1.0.1 #2

merged 1 commit into from
Feb 11, 2022

Conversation

leewang0
Copy link
Contributor

Description of the change

minor fix, printing the output of certain models reveals that the existing code has an issue when they contain raw dicts:

OpenAPITools/openapi-generator#10564

    def test_invoices_list(self):
        configuration = MergeAccountingClient.Configuration()

        # Swap YOUR_API_KEY below with your production key from:
        # https://app.merge.dev/configuration/keys
        configuration.api_key['tokenAuth'] = 'REDACTED'
        configuration.api_key_prefix['tokenAuth'] = 'Bearer'

        api_client = MergeAccountingClient.ApiClient(configuration)

        invoices_api_instance = InvoicesApi(api_client)

        # The string 'TEST_ACCOUNT_TOKEN' below works to test your connection
        # to Merge and will return dummy data in the response.
        # In production, replace this with account_token from user.

        x_account_token = 'REDACTED'

        try:
            api_response = invoices_api_instance.invoices_list(x_account_token)
            pprint.pprint(api_response)     # <------ this broke with the same stack trace from the github issue link above
        except MergeAccountingClient.ApiException as e:
            print('Exception when calling InvoicesApi->invoices_list: %s' % e)

The code change in this pr resolved it.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests, or the description above explains how testing was performed

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or gif attached. Download "Kap" from the Mac App store for easy gif screen capture.

@leewang0 leewang0 merged commit 223c108 into main Feb 11, 2022
@leewang0 leewang0 deleted the lee/1.0.1 branch February 11, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants