Polish apache#6198 : [Issue] Fixing NacosDynamicConfiguration#publish…

…Config bug
mercyblitz · Jun 11, 2020 · ab03f26 · ab03f26
1 parent e2b9b56
commit ab03f26
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...rc/main/java/org/apache/dubbo/metadata/store/AbstractAbstractWritableMetadataService.java b/...rc/main/java/org/apache/dubbo/metadata/store/AbstractAbstractWritableMetadataService.java
@@ -43,6 +43,9 @@ public abstract class AbstractAbstractWritableMetadataService implements Writabl
 
     @Override
     public void publishServiceDefinition(URL url) {
+        if (SERVICE_INTERFACE_NAME.equals(url.getServiceInterface())) { // Ignore the interface "MetadataService"
+            return;
+        }
         publishServiceDefinition(url.getServiceKey(), getServiceDefinition(url));
     }
 

diff --git a/...data-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java b/...data-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java
@@ -69,6 +69,11 @@ public MetadataReport getMetadataReport() {
 
     @Override
     public void publishServiceDefinition(URL url) {
+
+        if (SERVICE_INTERFACE_NAME.equals(url.getServiceInterface())) { // Ignore the interface "MetadataService"
+            return;
+        }
+
         String side = url.getParameter(SIDE_KEY);
         if (PROVIDER_SIDE.equalsIgnoreCase(side)) {
             //TODO, the params part is duplicate with that stored by exportURL(url), can be further optimized in the future.