Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable image validation webhook, requeue pool if no image found #76

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

rafalgalaw
Copy link
Collaborator

@rafalgalaw rafalgalaw commented Jan 17, 2024

Enables to independently apply a pool without having to apply the referenced image cr first. Tested the following scenarios:
Create:

  • create pool, referenced image cr does not exist yet -> pool error event, lastSyncError set, no id set as not created in garm

Update:

  • update pool with a non existent image cr -> pool error event, lastSyncError set
  • update pool to non existent image cr, delete pool -> pool gets deleted (old behaviour threw error)

Delete

  • delete image with reference to pool -> old behaviour, webhook denies it

@rafalgalaw
Copy link
Collaborator Author

rafalgalaw commented Jan 17, 2024

Todo:

  • add more unit tests to pool controller for create and update error scenarios

@rafalgalaw rafalgalaw marked this pull request as ready for review January 17, 2024 15:12
@rafalgalaw rafalgalaw merged commit f1dd79e into main Jan 23, 2024
3 checks passed
@rafalgalaw rafalgalaw deleted the feat/decouple-pool-image branch January 23, 2024 10:31
@rafalgalaw rafalgalaw linked an issue Feb 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow pool creation even if the referenced image doesn't exist yet
2 participants