fix: scale old runners only #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavarianbidi
force-pushed
the
pool-scaling/delete_long_running_idle_runners
branch
2 times, most recently
from
347b54a
to
6b3f41d
Compare
bavarianbidi
commented
Jan 15, 2024
rafalgalaw
reviewed
Jan 17, 2024
bavarianbidi
force-pushed
the
pool-scaling/delete_long_running_idle_runners
branch
2 times, most recently
from
75b1bff
to
2bd7e2c
Compare
bavarianbidi
commented
Jan 23, 2024
Comment on lines
+55
to
+61
| - `minIdleRunners` (on the `pool.spec`): defines the new value for `minIdleRunners` | ||
| - `minIdleRunnersAge` ([configured on the `operator` itself](config/configuration-parsing.md)): defines the age of the idle runners which should be removed | ||
|
|
||
| If the `minIdleRunnersAge` is set to `5m` and we scale down from `6` to `4`, `garm-operator` will only delete idle runners which are older than `5m`. | ||
|
|
||
| > [!IMPORTANT] | ||
| > The intention behind this approach was to prevent the deletion of to many idle runners as garm itself is responsible for the lifecycle of a runners in a pool. |
There was a problem hiding this comment.
We currently plan to move the minIdleRunnersAge into the pool.Spec in one of the future releases to make it configurable per pool
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
bavarianbidi
force-pushed
the
pool-scaling/delete_long_running_idle_runners
branch
from
0bc246c
to
b38bd34
Compare
rafalgalaw
approved these changes
Jan 23, 2024
bavarianbidi
deleted the
pool-scaling/delete_long_running_idle_runners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
pool.Status.Runners